From b1b781eda807bdbe6f771549bee7629a0fa7b702 Mon Sep 17 00:00:00 2001 From: wulan17 Date: Thu, 22 Jun 2023 01:16:06 +0700 Subject: [PATCH] Revert "Move to aiosqlite and enable WAL" This reverts commit afd2e3f0bc2af943873f33debc92bdfe5f56f2a6. Signed-off-by: wulan17 --- pyrogram/storage/file_storage.py | 31 ++++--- pyrogram/storage/memory_storage.py | 6 +- pyrogram/storage/sqlite_storage.py | 144 +++++++++++++++-------------- 3 files changed, 92 insertions(+), 89 deletions(-) diff --git a/pyrogram/storage/file_storage.py b/pyrogram/storage/file_storage.py index 76bd9cec..986787cd 100644 --- a/pyrogram/storage/file_storage.py +++ b/pyrogram/storage/file_storage.py @@ -18,7 +18,7 @@ import logging import os -import aiosqlite +import sqlite3 from pathlib import Path from .sqlite_storage import SQLiteStorage @@ -34,38 +34,39 @@ class FileStorage(SQLiteStorage): self.database = workdir / (self.name + self.FILE_EXTENSION) - async def update(self): - version = await self.version() + def update(self): + version = self.version() if version == 1: - await self.conn.execute("DELETE FROM peers") + with self.lock, self.conn: + self.conn.execute("DELETE FROM peers") version += 1 if version == 2: - await self.conn.execute("ALTER TABLE sessions ADD api_id INTEGER") + with self.lock, self.conn: + self.conn.execute("ALTER TABLE sessions ADD api_id INTEGER") version += 1 - await self.version(version) + self.version(version) async def open(self): path = self.database file_exists = path.is_file() - self.conn = await aiosqlite.connect(str(path), timeout=1) - - await self.conn.execute("PRAGMA journal_mode=WAL") + self.conn = sqlite3.connect(str(path), timeout=1, check_same_thread=False) if not file_exists: - await self.create() + self.create() else: - await self.update() + self.update() - try: # Python 3.6.0 (exactly this version) is bugged and won't successfully execute the vacuum - await self.conn.execute("VACUUM") - except aiosqlite.OperationalError: - pass + with self.conn: + try: # Python 3.6.0 (exactly this version) is bugged and won't successfully execute the vacuum + self.conn.execute("VACUUM") + except sqlite3.OperationalError: + pass async def delete(self): os.remove(self.database) diff --git a/pyrogram/storage/memory_storage.py b/pyrogram/storage/memory_storage.py index b59f2107..2c01f447 100644 --- a/pyrogram/storage/memory_storage.py +++ b/pyrogram/storage/memory_storage.py @@ -18,7 +18,7 @@ import base64 import logging -import aiosqlite +import sqlite3 import struct from .sqlite_storage import SQLiteStorage @@ -33,8 +33,8 @@ class MemoryStorage(SQLiteStorage): self.session_string = session_string async def open(self): - self.conn = await aiosqlite.connect(":memory:") - await self.create() + self.conn = sqlite3.connect(":memory:", check_same_thread=False) + self.create() if self.session_string: # Old format diff --git a/pyrogram/storage/sqlite_storage.py b/pyrogram/storage/sqlite_storage.py index 6608d7b3..15e5ddc0 100644 --- a/pyrogram/storage/sqlite_storage.py +++ b/pyrogram/storage/sqlite_storage.py @@ -17,7 +17,7 @@ # along with Pyrogram. If not, see . import inspect -import aiosqlite +import sqlite3 import time from threading import Lock from typing import List, Tuple, Any @@ -97,20 +97,22 @@ class SQLiteStorage(Storage): def __init__(self, name: str): super().__init__(name) - self.conn = None # type: aiosqlite.Connection + self.conn = None # type: sqlite3.Connection + self.lock = Lock() - async def create(self): - await self.conn.executescript(SCHEMA) + def create(self): + with self.lock, self.conn: + self.conn.executescript(SCHEMA) - await self.conn.execute( - "INSERT INTO version VALUES (?)", - (self.VERSION,) - ) + self.conn.execute( + "INSERT INTO version VALUES (?)", + (self.VERSION,) + ) - await self.conn.execute( - "INSERT INTO sessions VALUES (?, ?, ?, ?, ?, ?, ?)", - (2, None, None, None, 0, None, None) - ) + self.conn.execute( + "INSERT INTO sessions VALUES (?, ?, ?, ?, ?, ?, ?)", + (2, None, None, None, 0, None, None) + ) async def open(self): raise NotImplementedError @@ -118,27 +120,29 @@ class SQLiteStorage(Storage): async def save(self): await self.date(int(time.time())) - await self.conn.commit() + with self.lock: + self.conn.commit() async def close(self): - await self.conn.close() + with self.lock: + self.conn.close() async def delete(self): raise NotImplementedError async def update_peers(self, peers: List[Tuple[int, int, str, str, str]]): - await self.conn.executemany( - "REPLACE INTO peers (id, access_hash, type, username, phone_number)" - "VALUES (?, ?, ?, ?, ?)", - peers - ) + with self.lock: + self.conn.executemany( + "REPLACE INTO peers (id, access_hash, type, username, phone_number)" + "VALUES (?, ?, ?, ?, ?)", + peers + ) async def get_peer_by_id(self, peer_id: int): - q = await self.conn.execute( + r = self.conn.execute( "SELECT id, access_hash, type FROM peers WHERE id = ?", (peer_id,) - ) - r = await q.fetchone() + ).fetchone() if r is None: raise KeyError(f"ID not found: {peer_id}") @@ -146,12 +150,11 @@ class SQLiteStorage(Storage): return get_input_peer(*r) async def get_peer_by_username(self, username: str): - q = await self.conn.execute( + r = self.conn.execute( "SELECT id, access_hash, type, last_update_on FROM peers WHERE username = ?" "ORDER BY last_update_on DESC", (username,) - ) - r = await q.fetchone() + ).fetchone() if r is None: raise KeyError(f"Username not found: {username}") @@ -162,65 +165,64 @@ class SQLiteStorage(Storage): return get_input_peer(*r[:3]) async def get_peer_by_phone_number(self, phone_number: str): - q = await self.conn.execute( + r = self.conn.execute( "SELECT id, access_hash, type FROM peers WHERE phone_number = ?", (phone_number,) - ) - r = await q.fetchone() + ).fetchone() if r is None: raise KeyError(f"Phone number not found: {phone_number}") return get_input_peer(*r) - async def _get(self): + def _get(self): attr = inspect.stack()[2].function - q = await self.conn.execute( + return self.conn.execute( f"SELECT {attr} FROM sessions" - ) - return (await q.fetchone())[0] + ).fetchone()[0] - async def _set(self, value: Any): + def _set(self, value: Any): attr = inspect.stack()[2].function - await self.conn.execute( - f"UPDATE sessions SET {attr} = ?", - (value,) - ) - - async def _accessor(self, value: Any = object): - return await self._get() if value == object else await self._set(value) - - async def dc_id(self, value: int = object): - return await self._accessor(value) - - async def api_id(self, value: int = object): - return await self._accessor(value) - - async def test_mode(self, value: bool = object): - return await self._accessor(value) - - async def auth_key(self, value: bytes = object): - return await self._accessor(value) - - async def date(self, value: int = object): - return await self._accessor(value) - - async def user_id(self, value: int = object): - return await self._accessor(value) - - async def is_bot(self, value: bool = object): - return await self._accessor(value) - - async def version(self, value: int = object): - if value == object: - q = await self.conn.execute( - "SELECT number FROM version" - ) - return (await q.fetchone())[0] - else: - await self.conn.execute( - "UPDATE version SET number = ?", + with self.lock, self.conn: + self.conn.execute( + f"UPDATE sessions SET {attr} = ?", (value,) ) + + def _accessor(self, value: Any = object): + return self._get() if value == object else self._set(value) + + async def dc_id(self, value: int = object): + return self._accessor(value) + + async def api_id(self, value: int = object): + return self._accessor(value) + + async def test_mode(self, value: bool = object): + return self._accessor(value) + + async def auth_key(self, value: bytes = object): + return self._accessor(value) + + async def date(self, value: int = object): + return self._accessor(value) + + async def user_id(self, value: int = object): + return self._accessor(value) + + async def is_bot(self, value: bool = object): + return self._accessor(value) + + def version(self, value: int = object): + if value == object: + return self.conn.execute( + "SELECT number FROM version" + ).fetchone()[0] + else: + with self.lock, self.conn: + self.conn.execute( + "UPDATE version SET number = ?", + (value,) + )